Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create textDocument/documentSymbol to instance variables using shorthand assignment #2834

Conversation

vinibispo
Copy link
Contributor

Motivation

Resolves #2773

I'm doing this to solve problems of symbols not fetching shorthand instance variable assignments

Implementation

I've created three new listener methods to fetch operator_write_node_operator, or_write_node_operator, and and_write_node_operator

Automated Tests

Yes, I did

Manual Tests

@vinibispo vinibispo requested a review from a team as a code owner November 6, 2024 18:53
@vinibispo vinibispo changed the title Create text/documentSymbol to instance variables using shorthand assignment Create textDocument/documentSymbol to instance variables using shorthand assignment Nov 6, 2024
@andyw8 andyw8 added server This pull request should be included in the server gem's release notes bugfix This PR will fix an existing bug labels Nov 6, 2024
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@vinistock vinistock merged commit 15841f6 into Shopify:main Nov 21, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR will fix an existing bug server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Symbol request doesn't list shorthand assignments for instance variables
3 participants