Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in the activation script #2802

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

Earlopain
Copy link
Contributor

I for sure thought it would change meaning but turns out this space doesn't matter and the ast is the same.

I for sure thought it would change meaning but turns out this space doesn't matter and the ast is the same.
@Earlopain Earlopain requested a review from a team as a code owner October 30, 2024 10:23
@andyw8
Copy link
Contributor

andyw8 commented Oct 30, 2024

Interesting!

irb(main):010> defined?(RubyVM::YJIT)
=> "constant"
irb(main):011> defined?(RubyVM:: YJIT)
=> "constant"
irb(main):012> defined?(RubyVM ::YJIT)
=> nil
irb(main):013> defined?(RubyVM :: YJIT)
=> nil

@andyw8 andyw8 enabled auto-merge (squash) October 30, 2024 12:52
@andyw8 andyw8 added chore Chore task server This pull request should be included in the server gem's release notes labels Oct 30, 2024
@andyw8 andyw8 merged commit ffa9895 into Shopify:main Oct 30, 2024
20 of 21 checks passed
@Earlopain
Copy link
Contributor Author

You can add as many spaces to the right as you want. Might be a ruby bug, not sure, defined? is pretty weird.

@Earlopain
Copy link
Contributor Author

Oh. You can also just do this:

RubyVM:: YJIT
=> RubyVM::YJIT

So, not the fault of defined? and probably intended and/or for backwards compatibility.

@Earlopain Earlopain deleted the activation-script-typo branch October 30, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore task server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants