Show that server is running on degraded mode #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
enhancement
andyw8
reviewed
Oct 29, 2024
vinistock
force-pushed
the
vs-show-degraded-mode-status
branch
from
6b3dce9 to
af30248
Compare
andyw8
approved these changes
Oct 29, 2024
st0012
approved these changes
Oct 29, 2024
vinistock
force-pushed
the
vs-invoke-bundler-cli
branch
from
bbc0a44 to
0c4392b
Compare
vinistock
force-pushed
the
vs-show-degraded-mode-status
branch
from
af30248 to
8838642
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Let's show in the language status item if the server is running in degraded mode, so that it's easier to realize why full functionality may not be available.
Implementation
In essence, if there was an install or a setup error, then we are in degraded mode. We return that as part of the initialize result and use that to change the status entry message.
Automated Tests
Added a test.