Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notes for contributing to the Ruby LSP Rails add-on #2748

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Add notes for contributing to the Ruby LSP Rails add-on #2748

merged 1 commit into from
Oct 21, 2024

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Oct 21, 2024

No description provided.

@andyw8 andyw8 added documentation Improvements or additions to documentation chore Chore task labels Oct 21, 2024
@andyw8 andyw8 requested a review from a team as a code owner October 21, 2024 20:01
vinistock
vinistock reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put this in the contributing file of the Rails add-on itself and just link from here?

@andyw8
Copy link
Contributor Author

andyw8 commented Oct 21, 2024

I forgot we had that actually, let me put it there instead.

@andyw8 andyw8 closed this Oct 21, 2024
@andyw8
Copy link
Contributor Author

andyw8 commented Oct 21, 2024

Actually it's already covered, will update this PR to link to it.

@andyw8 andyw8 reopened this Oct 21, 2024
@andyw8 andyw8 force-pushed the andyw8/add-rails-addon-contrib-notes branch from 15373eb to 6b95a5e Compare October 21, 2024 20:10
@andyw8 andyw8 merged commit dd376e9 into main Oct 21, 2024
34 checks passed
@andyw8 andyw8 deleted the andyw8/add-rails-addon-contrib-notes branch October 21, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

Assignees
No one assigned
Labels
chore Chore task documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyw8 @vinistock