Make sure .ruby-lsp directory always exists
#2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will need the directory to inform the main process about the Gemfile path to setup Bundler with
vinistock
added
server
vinistock
changed the title
.ruby-lsp directory always exists
alexcrocha
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Another change aimed at the new launcher strategy. We will need to write the path to the Gemfile that needs to be used to setup Bundler to a file on every activation. That means, we will need the
.ruby-lspdirectory even when all gems are present in the bundle.Implementation
This PR ensures that the directory is always available.
Automated Tests
Modified existing tests. Removed the ones that aren't relevant anymore.