Only restart client if the contents of the watched files have changed #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
|
It worked for me. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Related to #2692
I don't know what in the user's setup is causing
.rubocop.ymlto be touched repeatedly, but we had issues in the past when the lockfile was continuously getting updated and we got into a restart loop.I think we should protect our file watchers from restarting when a file was touched, but the contents are still the same.
Implementation
Since the restart watchers are based on glob patterns, the idea is to let the first restart happen and remember the SHA of the content when we performed the restart. In subsequent file watch hits, we only restart if the contents were modified, otherwise we do nothing.