Ensure all ruby-lsp dependencies are installed before launch
#2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
andyw8
approved these changes
Oct 17, 2024
vinistock
force-pushed
the
vs-ensure-dependencies-are-installed
branch
from
707fe31 to
32585fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
One way launching the server may fail is if the user decided to uninstall one of our required dependencies for any reason.
For example, if you run
gem uninstall prismand delete all installations, launching the language server will fail because rubygems will raise saying not all dependencies are satisfied.Implementation
Our previous check was a bit too simple. We just verified if the
ruby-lspwas present, but in fact we need to verify that all dependencies are installed or else launching will fail.