Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make type optional in Index#entries_for #2667

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Make type optional in Index#entries_for #2667

merged 1 commit into from
Oct 4, 2024

Conversation

KaanOzkan
Copy link
Contributor

@KaanOzkan KaanOzkan commented Oct 4, 2024 •
edited
Loading

Motivation

Give more control to the user if the grep filtering logic isn't enough

Implementation

Automated Tests

Manual Tests

@KaanOzkan KaanOzkan requested a review from a team as a code owner October 4, 2024 14:33
@KaanOzkan KaanOzkan requested review from st0012 and vinistock October 4, 2024 14:33
@KaanOzkan KaanOzkan added enhancement New feature or request addons Tasks related to Ruby LSP addons server This pull request should be included in the server gem's release notes and removed addons Tasks related to Ruby LSP addons labels Oct 4, 2024
@KaanOzkan KaanOzkan changed the title Make type optional in Index#entries_for Make type optional in Index#entries_for Oct 4, 2024
@KaanOzkan KaanOzkan merged commit 90dc23c into main Oct 4, 2024
40 of 41 checks passed
@KaanOzkan KaanOzkan deleted the ko/entries-for branch October 4, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

@st0012 st0012 st0012 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request server This pull request should be included in the server gem's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaanOzkan @st0012 @vinistock