Run cspell in CI
#2622
Merged
Run cspell in CI
#2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
andyw8/cspell
branch
from
1d2b532 to
138c439
Compare
andyw8
commented
Sep 25, 2024
andyw8
commented
Sep 25, 2024
andyw8
commented
Sep 25, 2024
|
Oh nice, that caught a bunch of stuff already! Do we have to check in that new |
|
I suppose not. Updated. |
vinistock
reviewed
Sep 30, 2024
andyw8
force-pushed
the
andyw8/cspell
branch
4 times, most recently
from
c0e685f to
80e397d
Compare
|
Updated to only install |
vinistock
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
I'm slightly hesitant of making this a required part of CI. I agree that we should avoid typos and misspellings whenever possible, but I wonder if many PRs will end up being blocked on unknown terms and require regular updates to the cspell configuration.
I think there's no harm in trying this out, but if it becomes really annoying, then I will suggest removing the check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a VS Code
cspellconfiguration a while ago but it relies on people having the extension enabled, and noticing the things it detects. Instead, let's enforce this in CI. I've verified that the extension is still able to read the config.