Generalize scope so that it can be used with any locals #2603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There will be other cases where we want to track proper scope of locals. We can currently only track parameters, which is only used for semantic highlighting, but we can use this to provide renaming and references for locals too.
This PR turns our
ParameterScope
into a more generalScope
implementation, so that we can use it in other places.Implementation
I recommend reviewing by commit:
<<
method toadd
, so that we can pass more parametersAutomated Tests
Adapted existing tests.