Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix body line height for code #2598

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Fix body line height for code #2598

merged 1 commit into from
Sep 23, 2024

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Sep 23, 2024

By default, the just-the-docs theme sets the line height for code to match that of the body, resulting in some odd-looking gaps.

See just-the-docs/just-the-docs#932

Before:

Screenshot 2024-09-23 at 1 10 10 PM

After:

Screenshot 2024-09-23 at 1 09 56 PM

@andyw8 andyw8 requested a review from a team as a code owner September 23, 2024 17:29
@andyw8 andyw8 requested review from st0012 and vinistock September 23, 2024 17:29
@andyw8 andyw8 enabled auto-merge (squash) September 23, 2024 19:10
@andyw8 andyw8 added the chore Chore task label Sep 23, 2024
@andyw8 andyw8 merged commit a29808c into main Sep 23, 2024
36 checks passed
@andyw8 andyw8 deleted the andyw8/fix-body-line-height-for-code branch September 23, 2024 19:10
@andyw8 andyw8 restored the andyw8/fix-body-line-height-for-code branch September 24, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

@st0012 st0012 Awaiting requested review from st0012 st0012 is a code owner automatically assigned from Shopify/ruby-dx

Assignees
No one assigned
Labels
chore Chore task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyw8 @vinistock