Index forwarded parameters #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andy Waite <[email protected]>
vinistock
added
enhancement
st0012
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Step towards #2363
To support showing the correct overload in signature help, we need a way of verifying that a method call arity matches the method declaration arity.
When reviewing all parameter types and how we would match the arities, we noticed that we were not indexing forwarding parameters at all, which we need to do for the sake of completeness and proper matching.
Implementation
Added a new class for the forwarding parameter and started handling it in the declaration listener. Notice that you can't name a forwarding parameter, so I added an override for
initializethat forces the name to be....Automated Tests
Added tests.