-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uses Jekyll to generate the documentation #2536
Conversation
b59a674
to
a9f32ac
Compare
Saw these mentioned yesterday, could be useful if we want to use Tailwind for styling. https://github.com/skatkov/jekyll-tailwind-cli-template |
Is there somewhere else we could host the videos to avoid bloating the repo? They don't take up much space currently, but each time we update them the repo will grow. |
It's already there. |
Vini and I talked about this before, specifically with Git LFS as the potential solution. But IMO we should focus on improving the content until RailsWorld and then worry about this later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I left a couple of comments regarding the content, but I would rather have we move forward with the platform changes and then iterate on the content than holding this PR back
aca1187
to
0c54044
Compare
@vinistock because |
@st0012 would this work?
|
- Uses Jekyll to generate the documentation, which's source and configs live in the `/jekyll` folder. - The documentation will still be built to the `/docs` folder and be ignored by git. - Currently, the documentation is one big page (similar to rust-analyzer's). - All the current feature demos and introduction are copied from the Code Navigation post on the Rails At Scale blog. We will gradually fill in the rest of the documentation. - To avoid duplication, most of README's content has been moved to the documentation too. - Because Jekyll server isn't able to link to assets outside of the source directory, we need to copy the Ruby LSP icon to `/jekyll` folder.
Jekyll introduces a lot of dependencies that we don't need for developing Ruby LSP. Having a separate Gemfile for it should make dependencies easier to understand and manage.
Motivation
Compared to RDoc, Jekyll is a much better platform for non-API-focused documentation. Some useful features for us are:
_config.yml
Implementation
/jekyll
folder./docs
folder and be ignored by git./jekyll
folder.Demo
Screen.Recording.2024-09-10.at.21.44.44.mov
Automated Tests
Manual Tests