Inhibit server restarts during bisect as well #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
no-restart-during-bisect
branch
from
abd3526 to
02a2f4a
Compare
andyw8
reviewed
Sep 11, 2024
andyw8
reviewed
Sep 11, 2024
andyw8
reviewed
Sep 11, 2024
andyw8
approved these changes
Sep 11, 2024
andyw8
added
the
server
Earlopain
force-pushed
the
no-restart-during-bisect
branch
from
02a2f4a to
005c19e
Compare
vinistock
approved these changes
Sep 12, 2024
|
Thanks for merging! Should make bisecting large codebases much more bearable |
vinistock
added
vscode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a revival of what I wrote in #2387 (comment)
I consistently run into the issue of the lockfile changing during a bisect, restarting the server which then runs bundler, which blocks
bundler/inlinefrom processing until the gems are installed which may or may not finish in a reasonable amount of time.This stops the server from restarting when a bisect is in process, where the lockfile is likely to constantly change.
Implementation
Piggy-back of the already existing code for checking against a rebase. This does still cause additional restarts if you bisect during a rebase or the other way around but it seems very rare and this implementation is very simple.
Automated Tests
No. There are no tests for rebase
Manual Tests
Start a bisect, and observe that the server doesn't restart itself. Similarly, with a rebase