Protect method resolution from circular aliases #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
andyw8
reviewed
Aug 28, 2024
andyw8
approved these changes
Aug 28, 2024
vinistock
added
blocked
st0012
reviewed
Aug 28, 2024
| inherited_only: T::Boolean, | ||
| ).returns(T.nilable(T::Array[T.any(Entry::Member, Entry::MethodAlias)])) | ||
| end | ||
| def resolve_method(method_name, receiver_name, inherited_only: false) | ||
| def resolve_method(method_name, receiver_name, seen_names = [], inherited_only: false) |
There was a problem hiding this comment.
Not a big deal, but I feel these optional args would better be keyword args instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2497
We had a small level of protection against circular method aliases, but it was not enough for the case presented in the issue.
We need to keep track of
seen_names, just like we do for constant aliases, in order to prevent trying to re-process a name we're already found.Implementation
Added the
seen_namesarray for method aliases, which returns early before trying to recurse more if we find a name we've already seen.Automated Tests
Added a test that fails before the fix.