Always run Ruby activation using cmd for RubyInstaller #2489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2434
Our Ruby environment activation script doesn't work for Windows user who select their default shell as Powershell due to quote escaping issues.
I believe
cmd.exe
will always be available and it's the default option when invoking NodeJS'exec
function, so instead of trying to escape the script differently depending on the shell, I think we should just always runRubyInstaller
activation oncmd.exe
.Implementation
I created an override for
runScript
, which removes theshell
part forRubyInstaller
only.Automated Tests
Added a test verifying that we're not passing
shell
toexec
.