Disable diagnostics on large files #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
enhancement
st0012
reviewed
Aug 23, 2024
vinistock
force-pushed
the
vs-disable-diagnostics-on-large-files
branch
from
e12db10 to
dfe3aca
Compare
andyw8
reviewed
Aug 23, 2024
st0012
approved these changes
Aug 23, 2024
andyw8
reviewed
Aug 23, 2024
andyw8
reviewed
Aug 23, 2024
vinistock
force-pushed
the
vs-disable-diagnostics-on-large-files
branch
from
dfe3aca to
1e5029c
Compare
andyw8
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Similar to #2481, this PR disables "external diagnostics" for files with over 100k characters. Diagnostics such as syntax errors (collected by Prism) are still displayed, but linters like RuboCop are not shown.
Diagnostics runs on every keypress and trying to compute it for very large files ends up causing too much lag in the editor. After this PR, working on a ~4k line file is fully responsive, with response times around ~10-50ms.
Implementation
Just changed the message on did open and started returning before running RuboCop in large files.
Automated Tests
We don't have such a large file inside our codebase and we intentionally don't run diagnostics on files that are outside of the workspace, so I couldn't use Prism's
node.rbfile to write a test. I think this is simple enough that it's okay to skip it.