Add literal types to inferrer #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
enhancement
vinistock
force-pushed
the
vs-add-literal-types
branch
from
b2439e6 to
5855e79
Compare
|
Do we have a list of other literals not yet covered here? |
andyw8
approved these changes
Aug 21, 2024
Morriar
reviewed
Aug 21, 2024
vinistock
force-pushed
the
vs-add-literal-types
branch
from
5855e79 to
d3892fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR starts returning the expected type for literals, so that we can provide completion, go to definition, hover and signature help when something is invoked directly on one.
Implementation
I also fixed a minor bug that we had not caught. We were showing any type in the completion documentation as if it were a guessed type, but that should only appear if it was guessed.
Then I added a bunch of branches to cover literals.
Automated Tests
Added tests.