Run signature blocks ahead of time and compact after indexing #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
server
KaanOzkan
reviewed
Aug 19, 2024
st0012
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds two minor changes that may provide some performance gains.
Running all signatures ahead of time
This eliminates the need to run them on the first invocation of each method and eagerly unwraps the original method back in place. This will spend a bit more time during boot, but it should ensure that we see fewer of Sorbet's method wrapping logic in our stacks.
Compacting the GC after indexing
Indexing produces a lot of short lived objects for all of the ASTs of every file we interact with. This expands the heap pages a lot and may lead to some fragmentation. Compacting the GC helps us ensure that we're using the minimum number of pages needed and should make future GC runs a bit faster.