Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make configuration part of the index #2433

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Make configuration part of the index #2433

merged 1 commit into from
Aug 13, 2024
+17 −20

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Aug 13, 2024

Motivation

Since an Index's data is scoped by configuration, we should make the configuration part of the index. This is especially true with #2424 coming because changing the state of RubyIndexer.configuration to affect the index is surprising.

Implementation

  • Remove RubyIndexer.configuration
  • Initialize RubyIndexer::Configuration inside RubyIndexer::Index
  • Update all the RubyIndexer.cofniguration references

Automated Tests

Manual Tests

@st0012
Make configuration part of the index
6412dbc 
Since an Index's data is scoped by configuration, we should make the
configuration part of the index. This is especially true with #2424
coming because changing the state of `RubyIndexer.configuration` to
affect the index is surprising.
@st0012 st0012 added chore Chore task server This pull request should be included in the server gem's release notes labels Aug 13, 2024
@st0012 st0012 self-assigned this Aug 13, 2024
@st0012 st0012 requested a review from a team as a code owner August 13, 2024 11:45
@st0012 st0012 requested review from andyw8 and vinistock August 13, 2024 11:45
@st0012 st0012 force-pushed the remove-singleton-ruby-indexer-configuration branch from ed440ae to 6412dbc Compare August 13, 2024 11:45
@st0012 st0012 mentioned this pull request Aug 13, 2024
Merged
vinistock
vinistock approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor

@vinistock vinistock added other Changes that aren't bugfixes, enhancements or breaking changes and removed chore Chore task labels Aug 13, 2024
@st0012 st0012 merged commit 5055c4c into main Aug 13, 2024
38 checks passed
@st0012 st0012 deleted the remove-singleton-ruby-indexer-configuration branch August 13, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

@andyw8 andyw8 Awaiting requested review from andyw8 andyw8 is a code owner automatically assigned from Shopify/ruby-dx

Assignees

@st0012 st0012

Labels
other Changes that aren't bugfixes, enhancements or breaking changes server This pull request should be included in the server gem's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st0012 @vinistock