Require Ruby 3.1 in Gemfile #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ruby-lsp` gem supports 3.0 or above, but its `rbi` development dependency requires Ruby 3.1. And because dependabot always uses the lowest required Ruby to run the job, it's always failing to find the right `rbi` version. Hopefully this change will make dependabot use Ruby 3.1 and above instead.
andyw8
reviewed
Aug 2, 2024
| @@ -156,5 +156,8 @@ DEPENDENCIES | |||
| syntax_tree (>= 6.1.1, < 7) | |||
| tapioca (~> 0.13) | |||
|
|
|||
| RUBY VERSION | |||
| ruby 3.3.4p94 | |||
There was a problem hiding this comment.
🤔 will this be noisy if people have different patch levels of Ruby on their machines?
There was a problem hiding this comment.
It's the Ruby version bundler will prefer using. The ruby declaration in Gemfile though is a requirement.
st0012
added
the
server
|
Dependabot still decided to use Ruby 3.0.6 😅
|
st0012
added a commit
that referenced
this pull request
Aug 2, 2024
st0012
added a commit
that referenced
this pull request
Aug 2, 2024
* Revert #2405 as it doesn't work * Update rexml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ruby-lspgem supports 3.0 or above, but itsrbidevelopment dependency requires Ruby 3.1. And because dependabot always uses the lowest required Ruby to run the job, it's always failing to find the rightrbiversion.Hopefully this change will make dependabot use Ruby 3.1 and above instead.