Synchronize didOpen and didClose notifications #1901
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1897
In the server / base server refactor, we stopped running
didOpen
anddidClose
under a mutex lock, which is not correct.If we don't run it under a mutex lock, we risk having threads switch and trying to execute a different request before a file has been saved into the
Store
state, which will then try to find the document in the store, but won't find it.For files that haven't been saved yet (untitled:Untitled-1 URIs), that will end up trying to read from disk, which is guaranteed to fail since the file wasn't saved.
Implementation
We need to run
didOpen
anddidClose
under a mutex lock. We never want the threads to switch during those notifications.Automated Tests
It's quite hard to write a test for this, so I haven't added one.
Manual Tests
Manually testing is quite easy.