Automatically install ruby-lsp-rails as part of custom bundle
#1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
approved these changes
Feb 14, 2024
|
@vinistock I think we need a few more changes, e.g. ruby-lsp/lib/ruby_lsp/setup_bundler.rb Line 226 in c1ae8fd |
|
Ah, yeah. True. We need to add |
andyw8
force-pushed
the
andyw8/auto-install-ruby-lsp-rails
branch
3 times, most recently
from
282437b to
ae97b57
Compare
andyw8
commented
Feb 14, 2024
lib/ruby_lsp/setup_bundler.rb
Outdated
| ) | ||
|
|
||
| # If the user decided to add the `ruby-lsp` and `debug` to their Gemfile after having already run the Ruby LSP, | ||
| # If the user decided to add `ruby-lsp`, `ruby-lsp-rails` and `debug` to their Gemfile after having already run the Ruby LSP, |
There was a problem hiding this comment.
I'll need to reformat some of these comments to due the the line length, but I'll wait until the review is done.
|
If there was a chance we might need to add a fourth gem here, then I would consider refactoring this, since we need to repeat the list of 3 in many places currently. |
andyw8
force-pushed
the
andyw8/auto-install-ruby-lsp-rails
branch
from
ae97b57 to
3b5cf6e
Compare
|
Looks good to me |
|
(once this is merged, we can update the ruby-lsp-rails README to indicate that it doesn't need to be added to the Gemfile). |
andyw8
changed the title
ruby-lsp-rails as part of custom bundle
vinistock
reviewed
Feb 15, 2024
andyw8
force-pushed
the
andyw8/auto-install-ruby-lsp-rails
branch
from
2c2c236 to
67ee399
Compare
vinistock
reviewed
Feb 16, 2024
andyw8
force-pushed
the
andyw8/auto-install-ruby-lsp-rails
branch
from
67ee399 to
dc41d3a
Compare
andyw8
force-pushed
the
andyw8/auto-install-ruby-lsp-rails
branch
from
dc41d3a to
662dfba
Compare
vinistock
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With
ruby-lsp-railsv0.3.0, we switched away from the mounted Rack application approach. This meansruby-lsp-railscan now be used without having to add it to the app's Gemfile.Also closes #1267
Implementation
Previously we would install
debugandruby-lspinto the custom bundle. We now also installruby-lsp-railsif the app uses Rails.Automated Tests
Updated
Manual Tests
Verified.