replaced occurrences of node.slice with node.full_name #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
reviewed
Feb 5, 2024
haiderashfaq
force-pushed
the
replace_node_slice_with_full_name
branch
from
32566db to
143c0ce
Compare
|
The changes look good to me, but there are some type checking errors that have to be resolved. When we can't figure out the constant names, we should return early in most of them. |
vinistock
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1130
replaced occurrences of node.slice with node.full_name
handled
Prism::ConstantPathNode::DynamicPartsInConstantPathErrorwithfull_namepreviously opened PR reference #1131
was waiting on ruby/prism#1742 to get merged.