Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to rubyfmt extension #1286

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Add link to rubyfmt extension #1286

merged 1 commit into from
Jan 14, 2024

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Jan 8, 2024

No description provided.

@andyw8 andyw8 requested a review from a team as a code owner January 8, 2024 14:23
@andyw8 andyw8 requested review from egiurleo and KaanOzkan January 8, 2024 14:23
@andyw8 andyw8 force-pushed the andyw8/add-link-to-rubyfmt-ext branch from 73bd924 to 5581a9e Compare January 8, 2024 14:24
@andyw8 andyw8 marked this pull request as draft January 8, 2024 14:29
@andyw8
Copy link
Contributor Author

andyw8 commented Jan 8, 2024

@jscharf I opened this then realised the gem isn't yet published. Just let me know when it's ready and I'll merge this.

@jscharf
Copy link
Contributor

jscharf commented Jan 8, 2024

Thanks @andyw8! I did some work over the holidays to get it polished up a bit more. Updated some gems, added Github action for CI, updated to Ruby 3.3, etc.

Wanted to do that before publishing to make sure it was in a good place.

I don't have experience with publishing gems to RubyGems but I can look into it this week!

If you have time to take a quick look before publishing to make sure I didn't miss anything egregious or obvious I would definitely appreciate it! If not though no worries 👍

@jscharf
Copy link
Contributor

jscharf commented Jan 14, 2024

@andyw8 published to RubyGems.org at https://rubygems.org/gems/ruby-lsp-rubyfmt

@andyw8 andyw8 marked this pull request as ready for review January 14, 2024 19:55
@andyw8
Copy link
Contributor Author

andyw8 commented Jan 14, 2024

@andyw8 andyw8 merged commit bdd4ff8 into main Jan 14, 2024
30 of 36 checks passed
@andyw8 andyw8 deleted the andyw8/add-link-to-rubyfmt-ext branch January 14, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants