Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hover functionality for dependencies in Gemfile #1279

Merged
merged 10 commits into from
Jan 10, 2024
Merged

Add hover functionality for dependencies in Gemfile #1279

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d4f7962
Add hover functionality to dependencies in Gemfile
bravehager Jan 4, 2024
09bb766
Add test case
bravehager Jan 4, 2024
ab91a34
Always use currently loaded spec
bravehager Jan 4, 2024
bf9f939
Incorporate feedback
bravehager Jan 8, 2024
f23253b
Add additional test cases
bravehager Jan 8, 2024
806e94d
Remove unused instance variable
bravehager Jan 8, 2024
fb7dec5
Remove leading whitespace from gem info
bravehager Jan 9, 2024
a8bc251
Use safe navigation
bravehager Jan 9, 2024
6f69e7b
Cast info as String
bravehager Jan 9, 2024
50c5f85
Skip assertion on gem description
bravehager Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ruby_lsp/requests/hover.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ def generate_gem_hover(node)
end

# Remove leading whitespace if a heredoc was used for the summary or description
info = info.gsub(/^ +/, "") if info
info = info&.gsub(/^ +/, "")
bravehager marked this conversation as resolved.
Show resolved Hide resolved

markdown = <<~MARKDOWN
**#{spec.name}** (#{spec.version})
Expand Down