Remove BaseRequest

.github/workflows/ci.yml

@@ -19,9 +19,6 @@ jobs:
       - name: Check if documentation is up to date
         run: bundle exec rake ruby_lsp:check_docs
 
-      - name: Check if all requests are using valid visits
-        run: bundle exec rake check_visit_overrides
-
       - name: Typecheck
         run: bundle exec srb tc
 

dev.yml

@@ -20,7 +20,6 @@ commands:
     run: "bundle exec srb tc"
   ci:
     run: "bundle exec rake ruby_lsp:check_docs &&
-      bundle exec rake check_visit_overrides &&
       bundle exec srb tc &&
       bin/rubocop &&
       bin/test &&

lib/ruby_lsp/check_docs.rb

@@ -53,13 +53,16 @@ def run_task
       # documented
       features = ObjectSpace.each_object(Class).filter_map do |k|
         klass = T.unsafe(k)
-        klass if klass < Requests::BaseRequest || (klass < Listener && klass != ExtensibleListener)
+        klass_name = klass.name
+        next unless klass_name
+
+        klass if klass_name.match?(/RubyLsp::Requests::\w[^:]+$/) && !klass_name.include?("Support")
       end
 
       missing_docs = T.let(Hash.new { |h, k| h[k] = [] }, T::Hash[String, T::Array[String]])
 
       features.each do |klass|
-        class_name = T.must(klass.name)
+        class_name = klass.name
         file_path, line_number = Module.const_source_location(class_name)
         next unless file_path && line_number
 

lib/ruby_lsp/requests.rb

@@ -25,7 +25,6 @@ module RubyLsp
   # - [SignatureHelp](rdoc-ref:RubyLsp::Requests::SignatureHelp)
 
   module Requests
-    autoload :BaseRequest, "ruby_lsp/requests/base_request"
     autoload :DocumentSymbol, "ruby_lsp/requests/document_symbol"
     autoload :DocumentLink, "ruby_lsp/requests/document_link"
     autoload :Hover, "ruby_lsp/requests/hover"

lib/ruby_lsp/requests/code_action_resolve.rb

@@ -21,7 +21,7 @@ module Requests
     #
     # ```
     #
-    class CodeActionResolve < BaseRequest
+    class CodeActionResolve
       extend T::Sig
       NEW_VARIABLE_NAME = "new_variable"
 
@@ -36,12 +36,11 @@ class Error < ::T::Enum
 
       sig { params(document: Document, code_action: T::Hash[Symbol, T.untyped]).void }
       def initialize(document, code_action)
-        super(document)
-
+        @document = document
         @code_action = code_action
       end
 
-      sig { override.returns(T.any(Interface::CodeAction, Error)) }
+      sig { returns(T.any(Interface::CodeAction, Error)) }
       def run
         return Error::EmptySelection if @document.source.empty?
 

lib/ruby_lsp/requests/code_actions.rb

@@ -16,7 +16,7 @@ module Requests
     # puts "Hello" # --> code action: quick fix indentation
     # end
     # ```
-    class CodeActions < BaseRequest
+    class CodeActions
       extend T::Sig
 
       sig do
@@ -27,14 +27,13 @@ class CodeActions < BaseRequest
         ).void
       end
       def initialize(document, range, context)
-        super(document)
-
+        @document = document
         @uri = T.let(document.uri, URI::Generic)
         @range = range
         @context = context
       end
 
-      sig { override.returns(T.nilable(T.all(T::Array[Interface::CodeAction], Object))) }
+      sig { returns(T.nilable(T.all(T::Array[Interface::CodeAction], Object))) }
       def run
         diagnostics = @context[:diagnostics]
 

lib/ruby_lsp/requests/diagnostics.rb

@@ -18,17 +18,16 @@ module Requests
     # puts "Hello" # --> diagnostics: incorrect indentation
     # end
     # ```
-    class Diagnostics < BaseRequest
+    class Diagnostics
       extend T::Sig
 
       sig { params(document: Document).void }
       def initialize(document)
-        super(document)
-
+        @document = document
         @uri = T.let(document.uri, URI::Generic)
       end
 
-      sig { override.returns(T.nilable(T.all(T::Array[Interface::Diagnostic], Object))) }
+      sig { returns(T.nilable(T.all(T::Array[Interface::Diagnostic], Object))) }
       def run
         # Running RuboCop is slow, so to avoid excessive runs we only do so if the file is syntactically valid
         return syntax_error_diagnostics if @document.syntax_error?

lib/ruby_lsp/requests/formatting.rb

@@ -25,7 +25,7 @@ module Requests
     # puts "Hello" # --> formatting: fixes the indentation on save
     # end
     # ```
-    class Formatting < BaseRequest
+    class Formatting
       class Error < StandardError; end
       class InvalidFormatter < StandardError; end
 
@@ -55,13 +55,12 @@ def register_formatter(identifier, instance)
 
       sig { params(document: Document, formatter: String).void }
       def initialize(document, formatter: "auto")
-        super(document)
-
+        @document = document
         @uri = T.let(document.uri, URI::Generic)
         @formatter = formatter
       end
 
-      sig { override.returns(T.nilable(T.all(T::Array[Interface::TextEdit], Object))) }
+      sig { returns(T.nilable(T.all(T::Array[Interface::TextEdit], Object))) }
       def run
         return if @formatter == "none"
         return if @document.syntax_error?

lib/ruby_lsp/requests/on_type_formatting.rb

@@ -15,7 +15,7 @@ module Requests
     #   # <-- cursor ends up here
     # end # <-- end is automatically added
     # ```
-    class OnTypeFormatting < BaseRequest
+    class OnTypeFormatting
       extend T::Sig
 
       END_REGEXES = T.let(
@@ -28,8 +28,7 @@ class OnTypeFormatting < BaseRequest
 
       sig { params(document: Document, position: T::Hash[Symbol, T.untyped], trigger_character: String).void }
       def initialize(document, position, trigger_character)
-        super(document)
-
+        @document = document
         @lines = T.let(@document.source.lines, T::Array[String])
         line = @lines[[position[:line] - 1, 0].max]
 
@@ -40,7 +39,7 @@ def initialize(document, position, trigger_character)
         @trigger_character = trigger_character
       end
 
-      sig { override.returns(T.all(T::Array[Interface::TextEdit], Object)) }
+      sig { returns(T.all(T::Array[Interface::TextEdit], Object)) }
       def run
         case @trigger_character
         when "{"

lib/ruby_lsp/requests/show_syntax_tree.rb

@@ -17,17 +17,16 @@ module Requests
     # # (program (statements ((binary (int "1") + (int "1")))))
     # ```
     #
-    class ShowSyntaxTree < BaseRequest
+    class ShowSyntaxTree
       extend T::Sig
 
       sig { params(document: Document, range: T.nilable(T::Hash[Symbol, T.untyped])).void }
       def initialize(document, range)
-        super(document)
-
+        @document = document
         @range = range
       end
 
-      sig { override.returns(String) }
+      sig { returns(String) }
       def run
         return ast_for_range if @range