Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the Bundler UI level to silent to prevent output to stdout #1199

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

vinistock
Copy link
Member

Motivation

Fixes #1723

If users have Bundler's logging level configured to info or debug, internals will print to stdout and mess up the client/server communication. This happens when invoking methods like Bundler.locked_gems or specs. Here's an example.

We use these methods in two places

  • For setting up the custom bundle (which should hopefully go away as soon as bundler-compose is stable for usage
  • For figuring out which gems to index (won't go away)

Implementation

Set the Bundler UI level to silent so that it does not print anything regardless of user configurations. One of them will go away once we move to bundler-compose and just the one in internal will remain.

@vinistock vinistock added the bugfix This PR will fix an existing bug label Nov 22, 2023
@vinistock vinistock self-assigned this Nov 22, 2023
@vinistock vinistock requested a review from a team as a code owner November 22, 2023 15:03
@vinistock vinistock requested review from andyw8 and st0012 November 22, 2023 15:03
@vinistock vinistock merged commit 0ab62d6 into main Nov 22, 2023
30 checks passed
@vinistock vinistock deleted the vs/set_bundler_ui_level_to_silent branch November 22, 2023 15:50
@andyw8
Copy link
Contributor

andyw8 commented Aug 7, 2024

Note: This might not be working correctly if BUNDLE_AUTO_INSTALL is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR will fix an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header must provide a Content-Length property
2 participants