Declare all default gem dependencies in the gemspec #1125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
vinistock
force-pushed
the
vs/declare_all_default_gem_dependencies
branch
from
fcd2bc7 to
dd22269
Compare
vinistock
force-pushed
the
vs/declare_all_default_gem_dependencies
branch
from
dd22269 to
85fa858
Compare
|
As discussed in #1725, this is not really the right solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1725
@paracycle pointed out that the rubygems issue is likely because we depend on many default gems, but don't have them declared as runtime dependencies in the gemspec.
I tested this and it does make the issue go away.
Implementation