Update argument order for CodeLens initializer #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
changed the title
andyw8
force-pushed
the
andyw8/update-arg-order-codelens
branch
from
002bed7 to
e377bcf
Compare
vinistock
approved these changes
Sep 19, 2023
vinistock
pushed a commit
that referenced
this pull request
Feb 28, 2024
Co-authored-by: Andy Waite <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For consistency across requests, we prefer each request initializer has
emitterandmessage_queueas their final arguments.Implementation
Re-order the arugments.
Automated Tests
Updated.
Manual Tests
n/a.