Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Bundler lock problem #2387

Closed
andyw8 opened this issue Jul 30, 2024 · 4 comments · Fixed by #2505
Closed

Possible Bundler lock problem #2387

andyw8 opened this issue Jul 30, 2024 · 4 comments · Fixed by #2505

Comments

@andyw8
Copy link
Contributor

andyw8 commented Jul 30, 2024

A couple of times recently, running bundle on the command line has been hanging for me.

I spotted notices this issue, and found that killing off all the active Ruby processes on my machine solved the problem, so it seems something was indeed locking the update.

When it happens again, I can investigate more to try find the culprit.

cc @bdewater

@Earlopain
Copy link
Contributor

I ran into this, though I somewhat doubt it is related to the original issue. When bisecting, the gemfile.lock consistently changes and when it contains a few native extensions ruby-lsp tries to install/compile those, otherwise blocking bundler from doing its thing. Eventually the lock gets released when the install finishes, though it is highly annoying.

@andyw8
Copy link
Contributor Author

andyw8 commented Aug 14, 2024

Interesting. I wonder if we should detect if there's a bisect in progress, and avoid running Bundler if so.

@vinistock
Copy link
Member

If the Ruby LSP is already running bundle install, it indeed makes it impossible to run another bundle install process in the command line due to the lock. Honestly, I think that's the right behaviour since we wouldn't want two processes trying to compile and install the same gems.

That said, we should improve the Ruby LSP's bundle install reporting so that instead of just printing to STDERR, we show a progress notification (similar to indexing) with the current state of bundle install.

@Earlopain
Copy link
Contributor

A progress notification like that would be pretty nice to show whats going on a bit more prominently. It makes sense for bundler to not trip over itself but having to wait a minute for gems to finish compiling (gemfile specific of course) before you can continue bisecting is 😐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants