Add support for configuring path to ASDF executable (#2695)

* Add support for ASDF_ENV environment variable * Fix lint erros * Replace asdf dir variable with a extension setting * Refact description message for asdf path Co-authored-by: Vinicius Stock <[email protected]> * Handle exception when user supplied path for asdf was not found Co-authored-by: Vinicius Stock <[email protected]> * Apply lint suggestions --------- Co-authored-by: Vinicius Stock <[email protected]>
Shopify · Oct 18, 2024 · bb336e5 · bb336e5
1 parent 07b6dd8
commit bb336e5
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/vscode/package.json b/vscode/package.json
@@ -337,6 +337,10 @@
               ],
               "default": "auto"
             },
+            "asdfExecutablePath": {
+              "description": "The path to the asdf executable script, if not installed on one of the standard locations",
+              "type": "string"
+            },
             "miseExecutablePath": {
               "description": "The path to the Mise executable, if not installed in ~/.local/bin/mise",
               "type": "string"

diff --git a/vscode/src/ruby/asdf.ts b/vscode/src/ruby/asdf.ts
@@ -30,6 +30,24 @@ export class Asdf extends VersionManager {
     const scriptName =
       path.basename(vscode.env.shell) === "fish" ? "asdf.fish" : "asdf.sh";
 
+    const config = vscode.workspace.getConfiguration("rubyLsp");
+    const asdfPath = config.get<string | undefined>(
+      "rubyVersionManager.asdfExecutablePath",
+    );
+
+    if (asdfPath) {
+      const configuredPath = vscode.Uri.file(asdfPath);
+
+      try {
+        await vscode.workspace.fs.stat(configuredPath);
+        return configuredPath;
+      } catch (error: any) {
+        throw new Error(
+          `ASDF executable configured as ${configuredPath}, but that file doesn't exist`,
+        );
+      }
+    }
+
     // Possible ASDF installation paths as described in https://asdf-vm.com/guide/getting-started.html#_3-install-asdf.
     // In order, the methods of installation are:
     // 1. Git