wip

Shopify · Oct 18, 2023 · 7eaa826 · 7eaa826
1 parent 5ebdf78
commit 7eaa826
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/ruby_indexer/lib/ruby_indexer/entry.rb b/lib/ruby_indexer/lib/ruby_indexer/entry.rb
@@ -101,7 +101,7 @@ class Method < Entry
       sig { returns(T::Array[Parameter]) }
       attr_reader :parameters
 
-      sig { returns(String) }
+      sig { returns(T.nilable(String)) }
       attr_reader :namespace
 
       sig do
@@ -114,7 +114,7 @@ class Method < Entry
           namespace: T.nilable(String) # nilable or not?
         ).void
       end
-      def initialize(name, file_path, location, comments, parameters_node, namespace = nil)
+      def initialize(name, file_path, location, comments, parameters_node, namespace)
         super(name, file_path, location, comments)
         @parameters = T.let(list_params(parameters_node), T::Array[Parameter])
         @namespace = T.let(namespace, T.nilable(String))

diff --git a/lib/ruby_indexer/test/test_case.rb b/lib/ruby_indexer/test/test_case.rb
@@ -15,7 +15,7 @@ def index(source)
       @index.index_single(IndexablePath.new(nil, "/fake/path/foo.rb"), source)
     end
 
-    def assert_entry(expected_name, type, expected_location, expected_namespace)
+    def assert_entry(expected_name, type, expected_location, expected_namespace = nil)
       entries = @index[expected_name]
       refute_empty(entries, "Expected #{expected_name} to be indexed")
 
@@ -28,7 +28,7 @@ def assert_entry(expected_name, type, expected_location, expected_namespace)
           ":#{location.end_line - 1}-#{location.end_column}"
 
       assert_equal(expected_location, location_string)
-      assert_equal(expected_namespace, entry.namespace)
+      assert_equal(expected_namespace, entry.namespace) if expected_namespace
     end
 
     def refute_entry(expected_name)