Merge pull request #2591 from Shopify/ar/remove-experimental-flag

Remove --experimental flag

exe/ruby-lsp

@@ -29,13 +29,6 @@ parser = OptionParser.new do |opts|
     options[:branch] = branch
   end
 
-  opts.on(
-    "--experimental",
-    "Run pre-release versions of the Ruby LSP",
-  ) do
-    options[:experimental] = true
-  end
-
   opts.on("--doctor", "Run troubleshooting steps") do
     options[:doctor] = true
   end

lib/ruby_lsp/setup_bundler.rb

@@ -27,7 +27,6 @@ class BundleInstallFailure < StandardError; end
     def initialize(project_path, **options)
       @project_path = project_path
       @branch = T.let(options[:branch], T.nilable(String))
-      @experimental = T.let(options[:experimental], T.nilable(T::Boolean))
 
       # Regular bundle paths
       @gemfile = T.let(
@@ -207,7 +206,6 @@ def run_bundle_install(bundle_gemfile = @gemfile)
         command << "ruby-lsp " unless @dependencies["ruby-lsp"]
         command << "debug " unless @dependencies["debug"]
         command << "ruby-lsp-rails " if @rails_app && !@dependencies["ruby-lsp-rails"]
-        command << "--pre" if @experimental
         command.delete_suffix!(" ")
         command << ")"
 

test/setup_bundler_test.rb

@@ -301,38 +301,6 @@ def test_creates_custom_bundle_with_specified_branch
     end
   end
 
-  def test_install_prerelease_versions_if_experimental_is_true
-    Dir.mktmpdir do |dir|
-      Dir.chdir(dir) do
-        File.write(File.join(dir, "Gemfile"), <<~GEMFILE)
-          source "https://rubygems.org"
-          gem "rdoc"
-        GEMFILE
-
-        capture_subprocess_io do
-          Bundler.with_unbundled_env do
-            # Run bundle install to generate the lockfile
-            system("bundle install")
-
-            # Run the script once to generate a custom bundle
-            run_script(dir)
-          end
-        end
-
-        capture_subprocess_io do
-          Bundler.with_unbundled_env do
-            stub_bundle_with_env(
-              bundle_env(dir, ".ruby-lsp/Gemfile"),
-              "((bundle check && bundle update ruby-lsp debug --pre) || bundle install) 1>&2",
-            )
-
-            run_script(dir, experimental: true)
-          end
-        end
-      end
-    end
-  end
-
   def test_returns_bundle_app_config_if_there_is_local_config
     Dir.mktmpdir do |dir|
       Dir.chdir(dir) do