Fix version logging #342
Merged
Fix version logging #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
approved these changes
Apr 17, 2024
lib/ruby_lsp/ruby_lsp_rails/addon.rb
Outdated
| @@ -2,6 +2,7 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| require "ruby_lsp/addon" | |||
| require "ruby_lsp_rails/version" | |||
There was a problem hiding this comment.
Should this be require_relative like the below too?
There was a problem hiding this comment.
The ruby_lsp_rails directory is part of the default require path, so it'll always be in the $LOAD_PATH. The only reason the others are require_relative is because they are placed in non-standard paths.
andyw8
force-pushed
the
andyw8/fix-version-logging
branch
from
f1ea35d to
e1ad289
Compare
andyw8
force-pushed
the
andyw8/fix-version-logging
branch
from
e1ad289 to
bb2ae2d
Compare
vinistock
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent
VERSIONwrongly resolving to the one from ruby-lsp: https://github.com/Shopify/ruby-lsp/blob/main/lib/ruby-lsp.rb