Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on Rails #320

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Apr 4, 2024

Replaces #268

Since #284 changed how we check for Rails, there's no longer any need for the defined?(Rails) check discussed in #268.

@andyw8 andyw8 force-pushed the andyw8/remove-dependency-on-rails-2 branch from fa64812 to 98648c2 Compare April 4, 2024 15:07
@andyw8 andyw8 marked this pull request as ready for review April 4, 2024 15:10
@andyw8 andyw8 requested a review from a team as a code owner April 4, 2024 15:10
@andyw8 andyw8 requested review from Morriar, st0012 and vinistock and removed request for Morriar April 4, 2024 15:10
Copy link
Member

@paracycle paracycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@andyw8 andyw8 mentioned this pull request Apr 4, 2024
@andyw8 andyw8 merged commit a27a502 into main Apr 4, 2024
54 checks passed
@andyw8 andyw8 deleted the andyw8/remove-dependency-on-rails-2 branch April 4, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants