Skip to content

Commit

Permalink
Update for changes to index enhancements API (#529)
Browse files Browse the repository at this point in the history
* Temporarily point to branch

* Update for changes to enhancements API

* Update shim
  • Loading branch information
andyw8 authored Nov 21, 2024
1 parent a60d7e0 commit cba97f8
Show file tree
Hide file tree
Showing 10 changed files with 356 additions and 2,907 deletions.
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ PATH
remote: .
specs:
ruby-lsp-rails (0.3.26)
ruby-lsp (>= 0.21.2, < 0.22.0)
ruby-lsp (>= 0.22.0, < 0.23.0)

GEM
remote: https://rubygems.org/
Expand Down Expand Up @@ -214,7 +214,7 @@ GEM
rubocop (~> 1.51)
rubocop-sorbet (0.8.7)
rubocop (>= 1)
ruby-lsp (0.21.2)
ruby-lsp (0.22.0)
language_server-protocol (~> 3.17.0)
prism (>= 1.2, < 2.0)
rbs (>= 3, < 4)
Expand Down
1 change: 0 additions & 1 deletion lib/ruby_lsp/ruby_lsp_rails/addon.rb
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ def activate(global_state, outgoing_queue)
@outgoing_queue << Notification.window_log_message("Activating Ruby LSP Rails add-on v#{VERSION}")

register_additional_file_watchers(global_state: global_state, outgoing_queue: outgoing_queue)
@global_state.index.register_enhancement(IndexingEnhancement.new(@global_state.index))

# Start booting the real client in a background thread. Until this completes, the client will be a NullClient
@client_mutex.unlock
Expand Down
71 changes: 20 additions & 51 deletions lib/ruby_lsp/ruby_lsp_rails/indexing_enhancement.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,25 +8,18 @@ class IndexingEnhancement < RubyIndexer::Enhancement

sig do
override.params(
owner: T.nilable(RubyIndexer::Entry::Namespace),
node: Prism::CallNode,
file_path: String,
code_units_cache: T.any(
T.proc.params(arg0: Integer).returns(Integer),
Prism::CodeUnitsCache,
),
call_node: Prism::CallNode,
).void
end
def on_call_node_enter(owner, node, file_path, code_units_cache)
def on_call_node_enter(call_node)
owner = @listener.current_owner
return unless owner

name = node.name

case name
case call_node.name
when :extend
handle_concern_extend(owner, node)
handle_concern_extend(owner, call_node)
when :has_one, :has_many, :belongs_to, :has_and_belongs_to_many
handle_association(owner, node, file_path, code_units_cache)
handle_association(owner, call_node)
end
end

Expand All @@ -35,16 +28,11 @@ def on_call_node_enter(owner, node, file_path, code_units_cache)
sig do
params(
owner: RubyIndexer::Entry::Namespace,
node: Prism::CallNode,
file_path: String,
code_units_cache: T.any(
T.proc.params(arg0: Integer).returns(Integer),
Prism::CodeUnitsCache,
),
call_node: Prism::CallNode,
).void
end
def handle_association(owner, node, file_path, code_units_cache)
arguments = node.arguments&.arguments
def handle_association(owner, call_node)
arguments = call_node.arguments&.arguments
return unless arguments

name_arg = arguments.first
Expand All @@ -58,41 +46,22 @@ def handle_association(owner, node, file_path, code_units_cache)

return unless name

loc = RubyIndexer::Location.from_prism_location(name_arg.location, code_units_cache)
loc = name_arg.location

# Reader
@index.add(RubyIndexer::Entry::Method.new(
name,
file_path,
loc,
loc,
nil,
[RubyIndexer::Entry::Signature.new([])],
RubyIndexer::Entry::Visibility::PUBLIC,
owner,
))
reader_signatures = [RubyIndexer::Entry::Signature.new([])]
@listener.add_method(name, loc, reader_signatures)

# Writer
@index.add(RubyIndexer::Entry::Method.new(
"#{name}=",
file_path,
loc,
loc,
nil,
[RubyIndexer::Entry::Signature.new([RubyIndexer::Entry::RequiredParameter.new(name: name.to_sym)])],
RubyIndexer::Entry::Visibility::PUBLIC,
owner,
))
writer_signatures = [
RubyIndexer::Entry::Signature.new([RubyIndexer::Entry::RequiredParameter.new(name: name.to_sym)]),
]
@listener.add_method("#{name}=", loc, writer_signatures)
end

sig do
params(
owner: RubyIndexer::Entry::Namespace,
node: Prism::CallNode,
).void
end
def handle_concern_extend(owner, node)
arguments = node.arguments&.arguments
sig { params(owner: RubyIndexer::Entry::Namespace, call_node: Prism::CallNode).void }
def handle_concern_extend(owner, call_node)
arguments = call_node.arguments&.arguments
return unless arguments

arguments.each do |node|
Expand All @@ -101,7 +70,7 @@ def handle_concern_extend(owner, node)
module_name = node.full_name
next unless module_name == "ActiveSupport::Concern"

@index.register_included_hook(owner.name) do |index, base|
@listener.register_included_hook do |index, base|
class_methods_name = "#{owner.name}::ClassMethods"

if index.indexed?(class_methods_name)
Expand Down
2 changes: 1 addition & 1 deletion ruby-lsp-rails.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ Gem::Specification.new do |spec|
Dir["lib/**/*", "LICENSE.txt", "Rakefile", "README.md"]
end

spec.add_dependency("ruby-lsp", ">= 0.21.2", "< 0.22.0")
spec.add_dependency("ruby-lsp", ">= 0.22.0", "< 0.23.0")
end
Loading

0 comments on commit cba97f8

Please sign in to comment.