Fix reduce function being used incorrectly in core app path #306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: This PR improves performance
My goal here is to improve the code base, I noticed a bad practice happening in the code base and wanted to help. Also it could potentially hurt performance if this is used a lot in someone's code base.
The issue is how Javascript reduce is being used
When using reduce, you are allowed to use mutation when you just building from a new object, especially a place empty object as your initial value, this is because it is impossible to have a side effect in that case. You are simply building an object while assigning properties one by one in these examples.. However, you are creating new memory every single loop when you use the spread operator this way.
Reviewers’ hat-rack 🎩
This changes no behavior