Fix @shopify/hydrogen/experimental imports
#2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordofthecactus
approved these changes
Sep 28, 2022
| @@ -325,7 +325,7 @@ If your Store is based on the "Demo Store" tempate, and you are using the `test: | |||
| } from '@shopify/hydrogen/platforms'; | |||
|
|
|||
| // Platform entry handler | |||
| export default function(request) { | |||
| export default function (request) { | |||
juanpprieto
approved these changes
Sep 28, 2022
blittle
approved these changes
Sep 28, 2022
frehner
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
It's like a unique take on the "dual package hazard" haha.
A (probably worse, to be honest) alternative would be to add the "module" condition, which Vite matches before "import" and "require", but since you've said we don't even output to the node folder for this, I think your change is better.
This was referenced Sep 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1928
This makes tests in Shopify/hydrogen#2194 pass (cc @juanpprieto )
In-app logic such as components and hooks should always be imported from the
esnextbuild. In fact, we don't even createdist/node/<in-app-stuff>.The RSC plugin at some point runs
require.resolve('@shopify/hydrogen/experimental')and, since we are running in the CJS version of Vite, it was resolving to@shopify/hydrogen/dist/node/experimental.jsinstead of@shopify/hydrogen/dist/esnext/experimental.js. With this change, it always resolves to the latter.We can't run the ESM version of Vite until we migrate user apps to
type: "module".@frehner Tagging you here because I think this might be interesting for you.
Before submitting the PR, please make sure you do the following:
fixes #123)yarn changeset addif this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning