Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence ESLint warning on demo store #2034

Open
wants to merge 1 commit into
base: v1.x-2022-07
Choose a base branch
from
Open

Silence ESLint warning on demo store #2034

wants to merge 1 commit into from

Conversation

camelmasa
Copy link
Contributor

Description

We just silence ESLint warning.

Ref: https://github.com/Shopify/hydrogen/actions/runs/2915290955#artifacts

Before submitting the PR, please make sure you do the following:

  • Read the Contributing Guidelines
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)

frehner
frehner requested changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@frehner frehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should actually fix the warning instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frehner frehner frehner requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camelmasa @frehner