-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for sameSite option #2019
base: v1.x-2022-07
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Does this change affect tutorials or other docs?
I checked all docs in this repo. I don't think there is any other. |
I ignored that in CHANGELOG.md.
|
Ah, I need to change |
7372ab6
to
61a6c27
Compare
DONE! camelmasa@camelmasanoMacBook-Pro hydrogen % ag sameSite
docs/framework/hydrogen-config.md
173: sameSite: 'Strict',
docs/components/framework/cookie.md
19: sameSite: 'Strict',
39:| sameSite | <code>"Lax" | "Strict" | "None"</code> | Declares that the cookie should be restricted to a first-party or [same-site](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite) context. |
docs/components/framework/filesessionstorage.md
23: sameSite: 'Strict',
docs/components/framework/memorysessionstorage.md
22: sameSite: 'Strict',
docs/components/framework/cookiesessionstorage.md
22: sameSite: 'Strict',
examples/multipass/hydrogen.config.ts
13: sameSite: 'Strict',
packages/hydrogen/CHANGELOG.md
1123: sameSite: 'strict',
1165: - sameSite: 'strict',
1285: + sameSite: 'strict',
packages/hydrogen/src/foundation/Cookie/Cookie.ts
16: sameSite?: 'Lax' | 'Strict' | 'None';
packages/create-hydrogen-app/CHANGELOG.md
244: + sameSite: 'strict',
templates/demo-store/hydrogen.config.ts
20: sameSite: 'Strict', |
@rennyG Do we need to update other files? |
I did a search on this key/value in the |
Description
Just updated docs for
sameSite
option.Ref: https://github.com/Shopify/hydrogen/blob/ee370be6d74b330db78d95b85f1733c8ca3eb2d7/packages/hydrogen/src/foundation/Cookie/Cookie.ts#L16
Before submitting the PR, please make sure you do the following:
fixes #123
)