-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix app crash on prod #1794
Open
wizardlyhel
wants to merge
13
commits into
v1.x-2022-07
Choose a base branch
from
fix-app-crash
base: v1.x-2022-07
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix app crash on prod #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We detected some changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So far, the most consistent way to reproduce this bug is to:
might be easier to use a development oxygen instance to reproduce)Edit: Tried to reproduce this error in preview but was not able to. Gonna make a custom prod environment in admin to see if we can reproduce the error that way
Error we are seeing:
"Field 'cart' doesn't exist on type 'QueryRoot'"
- This is happening on theCartQuery($id: ID!...
query. - Suspecting this might be caused by an expired cart id. However, this should be a client-side network request and shouldn't make the app crashFrom server log
ERROR: Failed to connect to the Storefront API: Unable to parse response:
andERROR: {}
were observed. It seems that we got no response from SFAPI for some reason.Error seems to be happening on the SFAPI. In order to get more information, we need to place some logging to help us track down this bug:
x-request-id
in server log foruseShopQuery
requestsAdditional context
Before submitting the PR, please make sure you do the following:
fixes #123
)yarn changeset add
if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning