Cherry-pick commits to fix this branch on TruffleRuby #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* iseq_collector.c relies on many CRuby internals, there is no point to compile it on other Rubies.
* It now fails to compile on TruffleRuby:
../../../../ext/debug/iseq_collector.c: In function ‘imemo_type’:
../../../../ext/debug/iseq_collector.c:18:13: error: implicit declaration of function ‘RBASIC’ [-Werror=implicit-function-declaration]
18 | return (RBASIC(imemo)->flags >> FL_USHIFT) & imemo_mask;
| ^~~~~~
|
I'm closing this as we're not using this fork anymore. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes this branch of the gem installable on TruffleRuby.
The workaround for specific repos is to use
platform: :mriin the Gemfile, but it would be nice to fix this branch.It would also be good to rebase this work (if it is still necessary) against the master branch.
If it's not necessary, it would be good to delete so people do not adopt it in the future.