Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed safari swatch inputs in facets #3678

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tyleralsbury
Copy link
Contributor

@tyleralsbury tyleralsbury commented Nov 27, 2024

PR Summary:

Safari doesn't like just using top: 0; bottom: 0; ... to full size absolute positioned elements in a container, causing the swatches to have a much narrower click range than intended.

Why are these changes introduced?

Report from Merchant Support.

What approach did you take?

Added width and height to the checkbox.

Visual impact on existing themes

It won't.

Testing steps/scenarios

  • Open up Safari
  • Go to a collection page with colour swatches
  • See that you can now click the entire width of their line item, previously only the swatch itself could be clicked

Demo links

Checklist

@tyleralsbury tyleralsbury marked this pull request as ready for review November 27, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants