Updated splits from @mayonnaisical #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added menu splits for dash, dashmaster, dream nail, dream gate, void heart and 3 dreamers Added generic transition split for shade soul
Refactored all the menu splits and OrderedSplits(), splits no longer need to begin with "Menu", they all now use the plain MainMenu split via a conditional `goto case`. The menuSplitHelper variable now exists in the actual cases and the logic regarding it is for the most part done there. The code in OrderedSplits() has, as a result, become much simpler, and NotOrderedSplits() no longer properly supports menu splits.
changed like two lines of code and it works now, would previously split on the main menu multiple times
The autosplitter no longer supports unordered splits
Adjusted the logic in HandleSplits() to be simpler, I believe this does technically change the functionality of it, strictly speaking, will need some testing to confirm if it's good
Removed AnyTransition helper function, put the logic into split case itself TransitionAfterSaveState now goes to AnyTransition
Completely rewrote HandleSplits(), it now calls CheckSplit() directly in all cases Start and ending splits have been reworked now function as regular splits All splits are read as ordered splits, not possible to have unordered splits anymore Load removal code is untouched, logic around it adjusted so it may remove loads without any splits in the splits file, needs testing Updated readme, now contains information on creating your own splits and how to contribute
ok now this time i added the files Completely rewrote HandleSplits(), it now calls CheckSplit() directly in all cases Start and ending splits have been reworked now function as regular splits All splits are read as ordered splits, not possible to have unordered splits anymore Load removal code is untouched, logic around it adjusted so it may remove loads without any splits in the splits file, needs testing
don't listen to copilot apparently
Sorted the giant switch with all the SplitNames, general reformatting of that file a little bit Removed unordered splits option from the autosplitter UI I haven't gotten linting to work on linux yet so I'll probably find some syntax errors when I go to compile it
Changed the split condition to rely on specific rooms, split no longer works for NMG as it requires the specific rooms from the dupe
i really do need to get my c# extensions to work, shoutouts to python_wizard
idk what broke it or when but something about ending autosplits is broken
Fixed Shade Soul Transition Split
Added Has Shade Soul (Transition) autosplit that should be room dupe safe
I think menu splits are fixed now Cleaned up front end stuff in the splits menu
Replace EndingGodhome with RadianceP for Absolute Radiance in P5
Added Has Shade Soul (Transition)
Removed all traces of auto-start and auto-end splits mathulStonks Split files will no longer be fully backwards compatible anymore because of this Updated autosplitter settings UI to reflect the removed features as well I think i might have re-added the shade soul nmms split that isn't needed tho so nobody use that one
AlexKnauth
commented
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An updated version of slaurent22#27 to resolve merge conflicts.
door_dreamReturnis a discontinuity