Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lualine): add missing modes for command and terminal #45

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

daephx
Copy link
Contributor

@daephx daephx commented Dec 11, 2024

Add missing command and terminal mode colors to the ayu lualine theme

When using the use_mode_colors = true option for the window/tab components in lualine, the sections b and y may not display the correct colors due to the absence of color definitions for these modes within the theme script. Resulting in the highlight group, e.g. lualine_b_command being initialized with default (cleared) value.

While this issue might be related to how lualine handles highlight groups, the simplest solution is to add the missing mode configurations directly in the theme.

The command mode now uses colors.constant (violet), and the terminal mode uses the same color of insert mode, colors.string (green).


These screenshots are taken in the mirage theme, but the same applies to all variants.

Previous version: (inside terminal mode, shows improper highlights)

PqRHVRBOOl_1

Command mode:

PqRHVRBOOl_3

Terminal mode:

PqRHVRBOOl_2

Added missing `command` and `terminal` mode configurations to the
ayu lualine theme. This ensures proper styling for these modes in
the statusline.
@Shatur Shatur merged commit df06ef9 into Shatur:master Dec 15, 2024
2 checks passed
@Shatur
Copy link
Owner

Shatur commented Dec 15, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants