Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging support added #40

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

logging support added #40

wants to merge 3 commits into from

Conversation

harini-si
Copy link

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (232e7a8) compared to base (e55bf83).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff           @@
##            main     #40    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files          9      10     +1     
  Lines        186     290   +104     
======================================
- Misses       186     290   +104     
Impacted Files Coverage Δ
jeta/logger.py 0.00% <0.00%> (ø)
jeta/opti_trainer.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

jeta/logger.py Outdated Show resolved Hide resolved
import wandb


class Locallog:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class Locallog:
class LocalLog:

@veds12
Copy link
Member

veds12 commented Aug 24, 2022

@harini-si have tried running these on one of the existing algorithms? Perhaps it would be good to add logging to MAML - pass what kind of logger to use an an argument to the OptiTrainer and try running it to see if everything works as expected

Comment on lines +7 to +8
import tensorflow as tf
import wandb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do the lazy import for TensorFlow and wandb? Since these libraries will only be used in Iogging, I think having them as optional dependencies makes sense.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea. We can actually use lazy importing for most of the common dependencies here at a later point. But I don't mind doing this for wandb and tf now

Copy link
Member

@abhi-glitchhg abhi-glitchhg Aug 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for pandas.

Other modules are present in python 3 by default i suppose.

harini-si and others added 2 commits September 5, 2022 21:37
Copy link
Member

@abhi-glitchhg abhi-glitchhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think lazy importing can be handled like this.

Comment on lines +6 to +8
import pandas as pd
import tensorflow as tf
import wandb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import pandas as pd
import tensorflow as tf
import wandb

Comment on lines +65 to +66
"""

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""
"""
try:
import pandas as pd
except:
raise RuntimeError("Pandas not found. PD_Stats needs to have pandas installed. You can try installing pandas with pip: pip install pandas")

Comment on lines +91 to +92
"""

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""
"""
try:
import tensorflow as tf
except:
raise RuntimeError("Tensorflow not found. TensorboardLogger needs to have tensorflow installed. You can try installing tensorflow with pip: pip install tensorflow")

Comment on lines +127 to +128
"""

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""
"""
"""
try:
import wandb
except:
raise RuntimeError("Wandb not found. WandbLogger needs to have wandb installed. You can try installing wandb with pip: pip install wandb")

@@ -5,3 +5,4 @@ optax==0.1.3
pytest==6.2.5
typing-extensions==4.1.1
scipy==1.5
wandb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
wandb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants