-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging support added #40
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 0.00% // Head: 0.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 9 10 +1
Lines 186 290 +104
======================================
- Misses 186 290 +104
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
import wandb | ||
|
||
|
||
class Locallog: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class Locallog: | |
class LocalLog: |
@harini-si have tried running these on one of the existing algorithms? Perhaps it would be good to add logging to MAML - pass what kind of logger to use an an argument to the |
import tensorflow as tf | ||
import wandb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we do the lazy import for TensorFlow and wandb? Since these libraries will only be used in Iogging, I think having them as optional dependencies makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good idea. We can actually use lazy importing for most of the common dependencies here at a later point. But I don't mind doing this for wandb and tf now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for pandas.
Other modules are present in python 3 by default i suppose.
Co-authored-by: Vedant Shah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think lazy importing can be handled like this.
import pandas as pd | ||
import tensorflow as tf | ||
import wandb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import pandas as pd | |
import tensorflow as tf | |
import wandb |
""" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
""" | |
""" | |
try: | |
import pandas as pd | |
except: | |
raise RuntimeError("Pandas not found. PD_Stats needs to have pandas installed. You can try installing pandas with pip: pip install pandas") |
""" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
""" | |
""" | |
try: | |
import tensorflow as tf | |
except: | |
raise RuntimeError("Tensorflow not found. TensorboardLogger needs to have tensorflow installed. You can try installing tensorflow with pip: pip install tensorflow") |
""" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
""" | |
""" | |
""" | |
try: | |
import wandb | |
except: | |
raise RuntimeError("Wandb not found. WandbLogger needs to have wandb installed. You can try installing wandb with pip: pip install wandb") | |
@@ -5,3 +5,4 @@ optax==0.1.3 | |||
pytest==6.2.5 | |||
typing-extensions==4.1.1 | |||
scipy==1.5 | |||
wandb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wandb |
No description provided.