Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Menus pour la Ville #52

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from
Draft

[FEATURE] Menus pour la Ville #52

wants to merge 27 commits into from

Conversation

iambibi
Copy link
Collaborator

@iambibi iambibi commented Dec 30, 2024

Pour que votre Pull Request soit accepté, il vous faut :

  • Votre code suit-il le Code de Conduite ? : oui
  • Votre code se compile-il en local ? : oui
  • Avez-vous supprimez au maximum les imports non utilisé? : je vais le faire avec le sonar
  • Fournissez un Profileur (/spark profiler) lorsque vous éxécuter vos commandes, méthodes : https://spark.lucko.me/Myt1h0tw4y

Decrivez vos changements

Clairement et avec des screenshots si nécessaires
J'ai fini le menu de base il reste plus qu'a finir des menu.
J'ai ajouté une API de Sign car il est totalement impossible de le faire en 1.21.4 avec ProtocolLib. Il me faudrait NMS (net.minecraft.server) mais cela compliquerait la procédure de changement de version.
J'ai ajouté des Tests unitaires !

iambibi added 16 commits December 27, 2024 14:51
@iambibi
Fix Crash and ItemStack contestShell
c57c3a5
@iambibi
Change name of Bank City to Chest City
d0c745d
@iambibi
Add Structure of Menu
6fca58d
@iambibi
Add Structure of Menu (2)
9bdcf5e
@iambibi
Complete CityMenu + add getPlayerSkull
c338c40
@iambibi
Add ConfirmMenu ia
7f73658
@iambibi
Update ConfirmMenu
a7ba99b
@iambibi
Add Upgrade Button on ChestMenu
28d7cd2
@iambibi
Add Start of Bank Menu
b0a03a7
@iambibi
Add Menu of Bank City (Withdraw and Deposit)
aa99761 
- sign input
@iambibi
Fix error
06964e9
@iambibi
Merge remote-tracking branch 'origin/dev-city' into dev-city
9d3aed5 
# Conflicts:
#	src/main/java/fr/openmc/core/features/city/City.java
#	src/main/java/fr/openmc/core/features/city/CityManager.java
#	src/main/java/fr/openmc/core/features/city/listeners/ChestMenuListener.java
#	src/main/java/fr/openmc/core/features/city/menu/ChestMenu.java
@iambibi
Sonar Patch
15a6239
@iambibi
Change motd
7892188
@iambibi
Revert "Fix error"
88a2f74 
This reverts commit 06964e9.
@iambibi
Fix
3afe305
@iambibi iambibi changed the title [FEATURE] Commencement des Menus pour la Ville [FEATURE] Menus pour la Ville Dec 31, 2024
@iambibi iambibi marked this pull request as draft December 31, 2024 15:39
@iambibi
Copy link
Collaborator Author

iambibi commented Dec 31, 2024

J'ai changé le but de cette Pull Request pour eviter d'avoir quelques problèmes avec les branches.
Vous pouvez faire des remarques, suggestions, ect

@iambibi
Update and Fix of TransferMenu, CityMenu
b0138aa 
Fix java.lang.IllegalStateException: <CityEvent> may only be triggered synchronously. (2)

Fix java.lang.IllegalStateException: <CityEvent> may only be triggered synchronously.

Add New Menu (Transfer Owner, Rename, Delete)
@iambibi iambibi added bug Something isn't working enhancement New feature or request labels Dec 31, 2024
iambibi and others added 4 commits December 31, 2024 18:29
@iambibi
Fix of isInputCityName
9588176 
Fix of Methods
@iambibi
Merge branch 'master' into dev-city
6a17071
@iambibi
Fix builds
ee7b5db
@iambibi
Fixes
44b4ff8 
Fix ConcurrentModificationException

Fix forgetCity
Cela n'etait pas executé entierement. un try catch etait la solution

Add a option for execute methods with param in ConfirmMenu.java

Fix builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iambibi