IOS: Additional option for keychain access group #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marianJ97
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, i was just creating Wallet Extension and i realized that if you are using this package in RN, but you want to createSignature in another app, like extensions for ios...its not possible, because the private key is stored in keychain without opportunity to specify accessGroup attribute in kSec query. For now i added just that one option, but maybe later there could be added another attributes if needed and also for android.
Thank you if you look on it and i will be glad for some feedback or what to improve. Thank you
NOTE: in index.ts file is changed basically only createKeys function. Other changes should be only prettier formating