Update dependency org.seleniumhq.selenium:selenium-java to v4.21.0 (#…

…1720) * Update dependency org.seleniumhq.selenium:selenium-java to v4.21.0 * Updating deps and fixing code * Skipping test on macOS * Fixing hugo version * Fixing references --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Diego Molina <[email protected]>
SeleniumHQ · May 29, 2024 · eb60566 · eb60566
1 parent 77d830f
commit eb60566
Show file tree

Hide file tree

Showing 11 changed files with 35 additions and 71 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -15,7 +15,7 @@ jobs:
         with:
           fetch-depth: 0
       - name: Setup Hugo
-        uses: peaceiris/actions-hugo@75d2e84710de30f6ff7268e08f310b60ef14033f
+        uses: peaceiris/actions-hugo@v3
         with:
           hugo-version: ' 0.125.4'
           extended: true

diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml
@@ -19,9 +19,9 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Set up Hugo
-        uses: peaceiris/actions-hugo@75d2e84710de30f6ff7268e08f310b60ef14033f
+        uses: peaceiris/actions-hugo@v3
         with:
-          hugo-version: "0.110.0"
+          hugo-version: ' 0.125.4'
           extended: true
 
       - name: Setup Node
@@ -51,4 +51,4 @@ jobs:
         with:
           name: hyperlink-report
           path: website_and_docs/tmp/.hyperlink/hyperlink.log
-          retention-days: 7 # default is 90 days
+          retention-days: 7 # default is 90 days
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -15,7 +15,7 @@ jobs:
       - name: Checkout repo
         uses: actions/checkout@v4
       - name: Setup Hugo
-        uses: peaceiris/actions-hugo@75d2e84710de30f6ff7268e08f310b60ef14033f
+        uses: peaceiris/actions-hugo@v3
         with:
           hugo-version: '0.125.4'
           extended: true

diff --git a/examples/java/build.gradle b/examples/java/build.gradle
@@ -10,7 +10,7 @@ repositories {
 }
 
 dependencies {
-    testImplementation 'org.seleniumhq.selenium:selenium-java:4.20.0'
+    testImplementation 'org.seleniumhq.selenium:selenium-java:4.21.0'
     testImplementation 'org.junit.jupiter:junit-jupiter-engine:5.10.2'
 }
 

diff --git a/examples/java/pom.xml b/examples/java/pom.xml
@@ -13,7 +13,7 @@
         <maven.compiler.source>11</maven.compiler.source>
         <maven.compiler.target>11</maven.compiler.target>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <selenium.version>4.20.0</selenium.version>
+        <selenium.version>4.21.0</selenium.version>
     </properties>
 
     <repositories>

diff --git a/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/LocateNodesTest.java b/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/LocateNodesTest.java
@@ -47,7 +47,7 @@ void canLocateNodes() {
         BrowsingContext browsingContext = new BrowsingContext(driver, driver.getWindowHandle());
         driver.get("https://www.selenium.dev/selenium/web/xhtmlTest.html");
 
-        LocateNodeParameters parameters = new LocateNodeParameters.Builder(Locator.css("div")).build();
+        LocateNodeParameters parameters = new LocateNodeParameters(Locator.css("div"));
 
         List<RemoteValue> elements = browsingContext.locateNodes(parameters);
         Assertions.assertEquals(13, elements.size());
@@ -81,9 +81,8 @@ void canLocateNodesWithCSSLocator() {
         driver.get("https://www.selenium.dev/selenium/web/xhtmlTest.html");
 
         LocateNodeParameters parameters =
-                new LocateNodeParameters.Builder(Locator.css("div.extraDiv, div.content"))
-                        .setMaxNodeCount(1)
-                        .build();
+                new LocateNodeParameters(Locator.css("div.extraDiv, div.content"))
+                        .setMaxNodeCount(1);
 
         List<RemoteValue> elements = browsingContext.locateNodes(parameters);
 
@@ -101,9 +100,7 @@ void canLocateNodesWithXPathLocator() {
         driver.get("https://www.selenium.dev/selenium/web/xhtmlTest.html");
 
         LocateNodeParameters parameters =
-                new LocateNodeParameters.Builder(Locator.xpath("/html/body/div[2]"))
-                        .setMaxNodeCount(1)
-                        .build();
+                new LocateNodeParameters(Locator.xpath("/html/body/div[2]")).setMaxNodeCount(1);
 
         List<RemoteValue> elements = browsingContext.locateNodes(parameters);
 
@@ -121,9 +118,7 @@ void canLocateNodesWithInnerText() {
         driver.get("https://www.selenium.dev/selenium/web/xhtmlTest.html");
 
         LocateNodeParameters parameters =
-                new LocateNodeParameters.Builder(Locator.innerText("Spaced out"))
-                        .setMaxNodeCount(1)
-                        .build();
+                new LocateNodeParameters(Locator.innerText("Spaced out")).setMaxNodeCount(1);
 
         List<RemoteValue> elements = browsingContext.locateNodes(parameters);
 
@@ -139,44 +134,12 @@ void canLocateNodesWithMaxNodeCount() {
         driver.get("https://www.selenium.dev/selenium/web/xhtmlTest.html");
 
         LocateNodeParameters parameters =
-                new LocateNodeParameters.Builder(Locator.css("div")).setMaxNodeCount(4).build();
+                new LocateNodeParameters(Locator.css("div")).setMaxNodeCount(4);
 
         List<RemoteValue> elements = browsingContext.locateNodes(parameters);
         Assertions.assertEquals(4, elements.size());
     }
 
-    @Test
-    @Disabled
-    void canLocateNodesWithNoneOwnershipParameter() {
-        BrowsingContext browsingContext = new BrowsingContext(driver, driver.getWindowHandle());
-
-        driver.get("https://www.selenium.dev/selenium/web/xhtmlTest.html");
-
-        LocateNodeParameters parameters =
-                new LocateNodeParameters.Builder(Locator.css("div"))
-                        .setOwnership(ResultOwnership.NONE)
-                        .build();
-
-        List<RemoteValue> elements = browsingContext.locateNodes(parameters);
-        Assertions.assertFalse(elements.get(0).getHandle().isPresent());
-    }
-
-    @Test
-    @Disabled
-    void canLocateNodesWithRootOwnershipParameter() {
-        BrowsingContext browsingContext = new BrowsingContext(driver, driver.getWindowHandle());
-
-        driver.get("https://www.selenium.dev/selenium/web/xhtmlTest.html");
-
-        LocateNodeParameters parameters =
-                new LocateNodeParameters.Builder(Locator.css("div"))
-                        .setOwnership(ResultOwnership.ROOT)
-                        .build();
-
-        List<RemoteValue> elements = browsingContext.locateNodes(parameters);
-        Assertions.assertTrue(elements.get(0).getHandle().isPresent());
-    }
-
     @Test
     @Disabled
     void canLocateNodesGivenStartNodes() {
@@ -205,10 +168,9 @@ void canLocateNodesGivenStartNodes() {
                                 new RemoteReference(RemoteReference.Type.SHARED_ID, value.getSharedId().get())));
 
         LocateNodeParameters parameters =
-                new LocateNodeParameters.Builder(Locator.css("input"))
+                new LocateNodeParameters(Locator.css("input"))
                         .setStartNodes(startNodes)
-                        .setMaxNodeCount(50)
-                        .build();
+                        .setMaxNodeCount(50);
 
         List<RemoteValue> elements = browsingContext.locateNodes(parameters);
         Assertions.assertEquals(35, elements.size());
@@ -223,10 +185,9 @@ void canLocateNodesInAGivenSandbox() {
         browsingContext.navigate("https://www.selenium.dev/selenium/web/xhtmlTest.html", ReadinessState.COMPLETE);
 
         LocateNodeParameters parameters =
-                new LocateNodeParameters.Builder(Locator.css("div"))
+                new LocateNodeParameters(Locator.css("div"))
                         .setSandbox(sandbox)
-                        .setMaxNodeCount(1)
-                        .build();
+                        .setMaxNodeCount(1);
 
         List<RemoteValue> elements = browsingContext.locateNodes(parameters);
 

diff --git a/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java b/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java
@@ -11,6 +11,8 @@
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.condition.DisabledOnOs;
+import org.junit.jupiter.api.condition.OS;
 import org.openqa.selenium.bidi.module.Script;
 import org.openqa.selenium.bidi.browsingcontext.BrowsingContext;
 import org.openqa.selenium.bidi.script.LocalValue;
@@ -28,7 +30,7 @@ public void setup() {
         options.setCapability("webSocketUrl", true);
         driver = new FirefoxDriver(options);
     }
-    
+
     @Test
     void canListenToChannelMessage()
             throws ExecutionException, InterruptedException, TimeoutException {
@@ -50,6 +52,7 @@ void canListenToChannelMessage()
     }
 
     @Test
+    @DisabledOnOs(value = OS.MAC, disabledReason = "Works locally, times out on CI")
     void canListenToRealmCreatedEvent()
             throws ExecutionException, InterruptedException, TimeoutException {
         try (Script script = new Script(driver)) {

diff --git a/..._docs/content/documentation/webdriver/bidirectional/webdriver_bidi/script.en.md b/..._docs/content/documentation/webdriver/bidirectional/webdriver_bidi/script.en.md
@@ -284,7 +284,7 @@ This section contains the APIs related to script events.
 {{< tabpane text=true >}}
 {{< tab header="Java" >}}
 {{< badge-version version="4.16" >}}
-{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L52-L75" >}}
+{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L37-L51" >}}
 {{< /tab >}}
 {{< tab header="Ruby" >}}
 {{< badge-code >}}
@@ -303,7 +303,7 @@ This section contains the APIs related to script events.
 {{< tabpane text=true >}}
 {{< tab header="Java" >}}
 {{< badge-version version="4.16" >}}
-{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L55-L62" >}}
+{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L58-L68" >}}
 {{< /tab >}}
 {{< tab header="Ruby" >}}
 {{< badge-code >}}
@@ -322,7 +322,7 @@ This section contains the APIs related to script events.
 {{< tabpane text=true >}}
 {{< tab header="Java" >}}
 {{< badge-version version="4.16" >}}
-{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L72-L79" >}}
+{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L75-L85" >}}
 {{< /tab >}}
 {{< tab header="Ruby" >}}
 {{< badge-code >}}

diff --git a/..._docs/content/documentation/webdriver/bidirectional/webdriver_bidi/script.ja.md b/..._docs/content/documentation/webdriver/bidirectional/webdriver_bidi/script.ja.md
@@ -294,7 +294,7 @@ This section contains the APIs related to script events.
 {{< tabpane text=true >}}
 {{< tab header="Java" >}}
 {{< badge-version version="4.16" >}}
-{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L52-L75" >}}
+{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L37-L51" >}}
 {{< /tab >}}
 {{< tab header="Ruby" >}}
 {{< badge-code >}}
@@ -313,7 +313,7 @@ This section contains the APIs related to script events.
 {{< tabpane text=true >}}
 {{< tab header="Java" >}}
 {{< badge-version version="4.16" >}}
-{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L55-L62" >}}
+{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L58-L68" >}}
 {{< /tab >}}
 {{< tab header="Ruby" >}}
 {{< badge-code >}}
@@ -332,7 +332,7 @@ This section contains the APIs related to script events.
 {{< tabpane text=true >}}
 {{< tab header="Java" >}}
 {{< badge-version version="4.16" >}}
-{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L72-L79" >}}
+{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L75-L85" >}}
 {{< /tab >}}
 {{< tab header="Ruby" >}}
 {{< badge-code >}}

diff --git a/...cs/content/documentation/webdriver/bidirectional/webdriver_bidi/script.pt-br.md b/...cs/content/documentation/webdriver/bidirectional/webdriver_bidi/script.pt-br.md
@@ -294,7 +294,7 @@ This section contains the APIs related to script events.
 {{< tabpane text=true >}}
 {{< tab header="Java" >}}
 {{< badge-version version="4.16" >}}
-{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L52-L75" >}}
+{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L37-L51" >}}
 {{< /tab >}}
 {{< tab header="Ruby" >}}
 {{< badge-code >}}
@@ -313,7 +313,7 @@ This section contains the APIs related to script events.
 {{< tabpane text=true >}}
 {{< tab header="Java" >}}
 {{< badge-version version="4.16" >}}
-{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L55-L62" >}}
+{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L58-L68" >}}
 {{< /tab >}}
 {{< tab header="Ruby" >}}
 {{< badge-code >}}
@@ -332,7 +332,7 @@ This section contains the APIs related to script events.
 {{< tabpane text=true >}}
 {{< tab header="Java" >}}
 {{< badge-version version="4.16" >}}
-{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L72-L79" >}}
+{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L75-L85" >}}
 {{< /tab >}}
 {{< tab header="Ruby" >}}
 {{< badge-code >}}
@@ -344,4 +344,4 @@ This section contains the APIs related to script events.
 {{< tab header="Kotlin" >}}
 {{< badge-code >}}
 {{< /tab >}}
-{{< /tabpane >}}
+{{< /tabpane >}}
diff --git a/...cs/content/documentation/webdriver/bidirectional/webdriver_bidi/script.zh-cn.md b/...cs/content/documentation/webdriver/bidirectional/webdriver_bidi/script.zh-cn.md
@@ -294,7 +294,7 @@ This section contains the APIs related to script events.
 {{< tabpane text=true >}}
 {{< tab header="Java" >}}
 {{< badge-version version="4.16" >}}
-{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L52-L75" >}}
+{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L37-L51" >}}
 {{< /tab >}}
 {{< tab header="Ruby" >}}
 {{< badge-code >}}
@@ -313,7 +313,7 @@ This section contains the APIs related to script events.
 {{< tabpane text=true >}}
 {{< tab header="Java" >}}
 {{< badge-version version="4.16" >}}
-{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L55-L62" >}}
+{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L58-L68" >}}
 {{< /tab >}}
 {{< tab header="Ruby" >}}
 {{< badge-code >}}
@@ -332,7 +332,7 @@ This section contains the APIs related to script events.
 {{< tabpane text=true >}}
 {{< tab header="Java" >}}
 {{< badge-version version="4.16" >}}
-{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L72-L79" >}}
+{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/ScriptEventsTest.java#L75-L85" >}}
 {{< /tab >}}
 {{< tab header="Ruby" >}}
 {{< badge-code >}}
@@ -344,4 +344,4 @@ This section contains the APIs related to script events.
 {{< tab header="Kotlin" >}}
 {{< badge-code >}}
 {{< /tab >}}
-{{< /tabpane >}}
+{{< /tabpane >}}